Toolbar: add 'kebabLimit' option. #162
Conversation
martinpovolny
changed the title
martinpovolny
added
enhancement
martinpovolny
force-pushed
the
toolbar_3compr
branch
from
1631d24
to
6536910
Compare
Added option to configure the "kebabization" of the menu items. * kebabLimit === -1 means no compacting * kebabLimit === 0 means always compact into kebab * other values of give number of items to keep, before the rest is kebabized.
martinpovolny
force-pushed
the
toolbar_3compr
branch
from
6536910
to
8e1ef18
Compare
martinpovolny
changed the title
|
@martinpovolny can you update the snapshot please? |
| @@ -10,12 +10,46 @@ const wrapperComponent = () => ( | |||
| <React.Fragment> | |||
| <div className="toolbar-pf row"> | |||
| <Toolbar | |||
| count={1} | |||
There was a problem hiding this comment.
Can I ask what does the count does and why is it required?
There was a problem hiding this comment.
In manageiq the toolbar needs count of selected items in the GTL on the page.
Anyway: making it optional, adding default value.
martinpovolny
force-pushed
the
toolbar_3compr
branch
from
a457d8e
to
eca9656
Compare
|
Checked commits martinpovolny/react-ui-components@8e1ef18~...a0d656b with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
| @@ -91,17 +107,23 @@ export const Toolbar = props => ( | |||
| .filter(toolbarGroupHasContent) | |||
| .map((group, index) => | |||
| /* eslint react/no-array-index-key: "off" */ | |||
| <ToolbarGroup key={index} onClick={props.onClick} group={collapseCustomGroups(group)} />) | |||
| <ToolbarGroup key={index} onClick={props.onClick} group={collapseCustomGroups(group, props.kebabLimit)} />) | |||
There was a problem hiding this comment.
I suppose we don't have anything better than index right?
There was a problem hiding this comment.
Not for the group. But the index is stable.
|
🎉 This PR is included in version 0.11.57 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Added option to configure the "kebabization" of the menu items.
TODO
update specsadd specs for the new behaviorTesting
Running the
npm run servergives you an example of behavior for different values ofkebabLimit.BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1683703
Further changes:
countoptional the same askebabLimit(based on PR review feedback)