Fix non rails worker starting on podified

[agrare]

The current_pods Concurrent::Hash doesn't have the full pod object so we have to move the logic for checking if a pod is running down into save_pod

WIP pending tests covering more of these methods specifically sync_starting_workers

Dependents:

• Fix MiqServer WorkerManager Process with Non Rails workers #23117
• Link MiqWorker record to a running pod when not created using run_single_worker.rb #23112

[Fryguy]

@agrare Is this ready? (I still see WIP comment in the OP, so I wasn't sure)

[Fryguy]

@jrafanie Please also review.

[agrare]

Yeah I added the specs mentioned in the description

[Fryguy]

@agrare When we discussed, we talked about maybe treating all workers like non-rails workers, and removing the logic from run_single_worker. Is that a future thing and this is tactical, or did you go in a different direction?

[agrare]

When we discussed, we talked about maybe treating all workers like non-rails workers, and removing the logic from run_single_worker. Is that a future thing and this is tactical, or did you go in a different direction?

I found this issue while working on that, I have another PR that is built on this.

[agrare]

Hm the spec failures are green locally, wonder if something in another plugin broke master

[agrare]

That's very weird, I just restarted this without changing any commits and it is green now 🤷

[miq-bot]

Checked commits agrare/manageiq@281736e~...ed8d21a with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
4 files checked, 0 offenses detected
Everything looks fine. 🏆

[Fryguy]

LGTM - would like another set of eyes - @jrafanie ?

[jrafanie]

LGTM, just a minor question above.