Fix dialog tag specs #23078
Merged
Fix dialog tag specs #23078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
reviewed
Jul 3, 2024
.byebug_history
Outdated
There was a problem hiding this comment.
Recommend adding .byebug_history to your global gitignore ~/.gitignore so these don't get accidentally committed
There was a problem hiding this comment.
Oh I didn't notice those, should be fixed now.
GilbertCherrie
force-pushed
the
fix_dialog_tag_specs
branch
2 times, most recently
from
fe3a3c3
to
a6abff8
Compare
GilbertCherrie
force-pushed
the
fix_dialog_tag_specs
branch
from
a6abff8
to
04d71a9
Compare
|
Checked commit GilbertCherrie@04d71a9 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
agrare
approved these changes
Jul 4, 2024
|
Marking |
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Jul 9, 2024
Fix dialog tag specs (cherry picked from commit f133c62)
Fryguy
added a commit
that referenced
this pull request
Sep 6, 2024
…specs" This reverts commit bfdc01d.
|
Reverted the backport to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dialog tag specs as a follow up to this pr: ManageIQ/manageiq-automation_engine#545