[JANSA] [session_extension.rb] Fix superclass mismatch #21132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was changed in new versions of `actionpack`, and without this
change, the following error is given:
TypeError:
superclass mismatch for class TestSession
# actionpack-6.0.3.3/lib/action_controller/test_case.rb:179:in `<module:ActionController>'
# ...
# ./spec/spec_helper.rb:11:in `<top (required)>'
No examples found.
NickLaMuro
changed the title
NickLaMuro
changed the title
|
@jrafanie you're a constant problem... |
Fryguy
changed the title
|
build for this is causing failures on Jansa - pretty sure it is basic sporadic failures that re resolved elsewhere
they have been back-ported and this should no longer be an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of d8114bf which is from the Rails 6.0 PR since rails/rails@13a0726 was backported to Rails 5.2 recently.
Original commit message below:
This was changed in new versions of
actionpack, and without this change, the following error is given:Links
Steps for Testing/QA
Hopefully will make the tests pass.