Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on the default value for ImagePullPolicy #20279

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

carbonin
Copy link
Member

Now we will set the pull policy to always if the tag matche .latest.
and also explicitly set it to IfNotPresent otherwise.

Now we will set the pull policy to always if the tag matche .*latest.*
and also explicitly set it to IfNotPresent otherwise.
@miq-bot
Copy link
Member

miq-bot commented Jun 16, 2020

Checked commit carbonin@f87ce5a with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@bdunne bdunne merged commit 1c4e294 into ManageIQ:master Jun 16, 2020
simaishi pushed a commit that referenced this pull request Jun 18, 2020
Don't rely on the default value for ImagePullPolicy

(cherry picked from commit 1c4e294)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit ace5445485cb3b2b681f971ea56e4e14f8352787
Author: Brandon Dunne <bdunne@redhat.com>
Date:   Tue Jun 16 10:30:18 2020 -0400

    Merge pull request #20279 from carbonin/explicity_set_pull_policy

    Don't rely on the default value for ImagePullPolicy

    (cherry picked from commit 1c4e2940fb4deb01aef3f8986950f7315fb13717)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants