[WIP] Extract NetworkManager parent_manager to a mixin

[agrare]

Extract the logic for a NetworkManager belonging to a CloudManager parent out of the base NetworkManager class and move it to a mixin. This allows for the standard logic for deciding if a manager can be created directly to be used (aka does it have a belongs_to :parent_manager reflection) for the standalone network providers like Nuage and NSX-t.

Dependents:

• [WIP] Amazon::NetworkManager belongs to a parent manager manageiq-providers-amazon#627
• [WIP] Azure::NetworkManager belongs to parent manager manageiq-providers-azure#398
• [WIP] AzureStack::NetworkManager belongs to a parent manager manageiq-providers-azure_stack#33
• [WIP] Google::NetworkManager belongs to a parent manager manageiq-providers-google#138
• [WIP] Openstack::NetworkManager belongs to a parent manager manageiq-providers-openstack#603
• [WIP] Ovirt::NetworkManager belongs to a parent manager manageiq-providers-ovirt#498
• [WIP] Vmware::NetworkManager belongs to a parent manager manageiq-providers-vmware#585

Cross Repo Tests: ManageIQ/manageiq-cross_repo-tests#136

[agrare]

@gtanzillo @lpichler question (re: #18504), the belongsto_descendant_class seems to only work on base-classes but not all NetworkManagers belong to a parent_manager.

Is there a way to get this find_object_by_special_class to respect sub-classes?

[kbrock]

Really like the factory changes.
Don't see where you are mixing this into NetworkManager (yes, WIP...)

These methods are white noise.
Wish we could delete them rather than hiding them behind a mixin.

[kbrock]

different PR:

would be nice if we used has_many :through instead.
Though, that will not work for virtual relationships on the manager model

[miq-bot]

Checked commits agrare/manageiq@e01e164~...832ac8a with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
4 files checked, 21 offenses detected

app/models/manageiq/providers/network_manager.rb

• ❗ - Line 39, Col 13 - Style/RedundantSelf - Redundant self detected.
• ❗ - Line 40, Col 42 - Style/RedundantSelf - Redundant self detected.

app/models/mixins/belongs_to_parent_manager_mixin.rb

• ❗ - Line 12, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 13, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 14, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 15, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 16, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 17, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 18, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 19, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 20, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 21, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 22, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 23, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 24, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 25, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 26, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 27, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 28, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 29, Col 5 - Rails/InverseOf - Specify an :inverse_of option.
• ❗ - Line 7, Col 5 - Rails/InverseOf - Specify an :inverse_of option.

[agrare]

Really like the factory changes.

Yeah I'm considering pulling just those out into its own PR since nuage and nsx-t having a parent manager isn't accurate even without this mixin

Don't see where you are mixing this into NetworkManager (yes, WIP...)

That's actually done in the provider PRs