Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional privilege escalation methods #20019

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Add additional privilege escalation methods #20019

merged 1 commit into from
Mar 30, 2020

Conversation

carbonin
Copy link
Member

@carbonin carbonin commented Mar 27, 2020 •
edited
Loading

Changed this list to match the output of ansible-doc -t become -l from our latest appliance

image

Fixes #18470

@carbonin carbonin requested a review from agrare as a code owner March 27, 2020 15:40
@Fryguy
Copy link
Member

Fryguy commented Mar 27, 2020 •
edited
Loading

@carbonin Are these all supported by regular ansible (i.e. not a tower/awx add-on)?

I'm asking because we should only support whatever pure ansible has, not tower.

@carbonin
Copy link
Member Author

carbonin commented Mar 27, 2020 •
edited
Loading

Actually according to my comment #18470 (comment) I think I'm missing doas in this PR.

That said, I think these can probably vary based on the ansible version and distribution, that's why I originally suggested making this dynamic, but I didn't really want to shell out to ansible-doc at load time do resolve this constant.

@carbonin
Add additional privilege escalation methods
2b3ab9f 
Changed this list to match the output of
`ansible-doc -t become -l` from our latest appliance

Fixes ManageIQ#18470
@carbonin carbonin force-pushed the add_more_priv_escalation_options branch from 7a93d18 to 2b3ab9f Compare March 27, 2020 20:38
@miq-bot
Copy link
Member

miq-bot commented Mar 27, 2020

Checked commit carbonin@2b3ab9f with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@chessbyte chessbyte self-assigned this Mar 30, 2020
@chessbyte chessbyte merged commit 4d81350 into ManageIQ:master Mar 30, 2020
@carbonin carbonin deleted the add_more_priv_escalation_options branch March 30, 2020 15:36
simaishi pushed a commit that referenced this pull request Apr 16, 2020
@chessbyte @simaishi
Merge pull request #20019 from carbonin/add_more_priv_escalation_options
02ee3a9 
Add additional privilege escalation methods

(cherry picked from commit 4d81350)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit 02ee3a96e7ed4b2026cf2a94d972e9b4189bffc0
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Mon Mar 30 11:04:44 2020 -0400

    Merge pull request #20019 from carbonin/add_more_priv_escalation_options

    Add additional privilege escalation methods

    (cherry picked from commit 4d813505dda28cab569c6dc352cd0a7c6bf04d05)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare Awaiting requested review from agrare agrare is a code owner

Assignees

@chessbyte chessbyte

Labels
core/embedded ansible enhancement jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embedded Ansible become_method options
5 participants
@carbonin @Fryguy @miq-bot @simaishi @chessbyte