Make monolithic image work when built with buildah #19920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of these changes were made to ivanchuk in #19919 |
|
cc @simaishi after this you can use |
bdunne
reviewed
Mar 3, 2020
|
Checked commits carbonin/manageiq@41d7c4f~...d137874 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint |
Oh nice. All pods images can be built using podman/buildah as well? If so, we can probably switch to or at least make it an option in pods build script. |
I believe so. |
simaishi
pushed a commit
that referenced
this pull request
Mar 12, 2020
Make monolithic image work when built with buildah (cherry picked from commit d013803)
|
This is in ivanchuk branch (via #19919), so backported to jansa. Also, without this change, it fails to build on our build machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the volume commands down to avoid running into containers/buildah#2202 when using podman or buildah to create the image.
Additionally it removes some unnecessary ssh configuration as we haven't been running sshd since we removed systemd from this image.