Schedule compliance purging #19264
Merged
Schedule compliance purging #19264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
force-pushed
the
schedule_compliance_purge_or_whatever
branch
9 times, most recently
from
c316d01
to
9497005
Compare
d-m-u
force-pushed
the
schedule_compliance_purge_or_whatever
branch
2 times, most recently
from
cda6c5f
to
fe68819
Compare
gtanzillo
reviewed
Sep 6, 2019
d-m-u
force-pushed
the
schedule_compliance_purge_or_whatever
branch
from
fe68819
to
51f4a51
Compare
|
Checked commit d-m-u@51f4a51 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
kbrock
approved these changes
Sep 6, 2019
| where(arel_table[:timestamp].lteq(older_than)) | ||
| end | ||
|
|
||
| def purge_associated_records(ids) |
There was a problem hiding this comment.
TANGENT: I do wonder if we could pass scopes into purge_associated_records
no action required
kbrock
reviewed
Sep 6, 2019
| @@ -74,6 +74,10 @@ | |||
| :memory_method_description: High Normal Range of Allocated Memory | |||
| :failover: | |||
| :rule: discovered | |||
| :compliances: | |||
| :history: | |||
| :keep_compliances: 6.months | |||
There was a problem hiding this comment.
@jcarter12 Do you have a suggestion for this value?
|
we can merge and backport to 5.8 for the issue that LJ and Jared were looking at yesterday |
gtanzillo
approved these changes
Sep 10, 2019
|
@miq-bot add_label changelog/yes |
|
@d-m-u can this be |
simaishi
pushed a commit
that referenced
this pull request
Nov 1, 2019
…tever Schedule compliance purging (cherry picked from commit 87935ce) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767808
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compliances should be purged, it's on a
weeklydaily basis just the same as things mentioned in #19264 (comment) but honestly I don't even know anything at all about how often it should happen so feel free to argueFor https://bugzilla.redhat.com/show_bug.cgi?id=1733641 but really it's just up because I want to get people talking about it. @gtanzillo @yrudman @jrafanie maybe @kbrock, I dunno