Fixes multiple issues with job show page #19232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a new `EmbeddedAnsible::AutomationManager::Job` (aka, an `OrchestrationStack`), make sure we are saving the verbosity from the options we are running the job with. We can fetch this after, but the service template (?) might change in the future, so save off this value as part of the job record to ensure we are keeping track of this value when it was run. https://bugzilla.redhat.com/show_bug.cgi?id=1741883
This uses a bit of duplicate code from the `.collect_credentials` method from `EmbeddedAnsible::AutomationManager::ConfigurationScript`, but it was simpler at the time to just copy that code in here for the time being. Effectively assign records for the `.authentications` association for the job so that it can be fetch in the `ServiceHelper::TextualSummary` in the UI.
|
cc @dmetzger57 |
Fryguy
changed the title
|
Checked commits Fryguy/manageiq@e5be302~...b065c9c with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
NickLaMuro
approved these changes
Aug 30, 2019
bdunne
reviewed
Aug 30, 2019
app/models/manageiq/providers/embedded_ansible/automation_manager/job.rb
Show resolved
Hide resolved
simaishi
pushed a commit
that referenced
this pull request
Sep 4, 2019
Fixes multiple issues with job show page (cherry picked from commit 521b41c) https://bugzilla.redhat.com/show_bug.cgi?id=1741883
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the 2 less complicated fixes from #19215 . For details, read that PR.
https://bugzilla.redhat.com/show_bug.cgi?id=1741883