Add copying tag as optional choice #19206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @tinaafitz |
astrozzc
force-pushed
the
template_copy_tags
branch
from
fd73a5d
to
7ddb0d7
Compare
|
@miq-bot add_label enhancement, ivanchuk/yes, services, changelog/yes |
astrozzc
force-pushed
the
template_copy_tags
branch
from
7ddb0d7
to
8fe3fa7
Compare
gmcculloug
reviewed
Aug 29, 2019
|
|
||
| new_template = service_template.template_copy | ||
|
|
||
| expect(new_template.tags.count).to eq(0) |
There was a problem hiding this comment.
Instead of eq(0) use be_zero
There was a problem hiding this comment.
Good to know that!
|
|
||
| new_template = service_template.template_copy(:copy_tags => true) | ||
|
|
||
| expect(new_template.tags.count).to eq(2) |
There was a problem hiding this comment.
We should be checking that the tags on the new_template match the original template, not just the count.
You can do that with expect(new_template.tags).to match_array(service_template.tags)
There was a problem hiding this comment.
Thanks for catching this!
When service template is copied, tags might also need to be copied as requested. This change adds an optional filed to allow tags to be copied as well.
astrozzc
force-pushed
the
template_copy_tags
branch
from
8fe3fa7
to
09159b3
Compare
|
Checked commit astrozzc@09159b3 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
tinaafitz
approved these changes
Sep 3, 2019
|
🎉 Thanks for the PR @astrozzc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When service template is copied, tags might also need to be copied as well. This change adds an optional filed to allow tags to be copied as well.
https://bugzilla.redhat.com/show_bug.cgi?id=1740399