Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated VMWare Hosts #19159

Merged

Conversation

GregP
Copy link
Contributor

@GregP GregP commented Aug 15, 2019

Fix and remove deprecated VMWware Hosts from selection/display.

NOTE: Requires this BZ fix to work: https://bugzilla.redhat.com/show_bug.cgi?id=1740309

https://bugzilla.redhat.com/show_bug.cgi?id=1740738

Screen shot showing older versions of VMWare:
Hosts list with older ESX versions prior to code fix

Screen shot showing only recent versions listed:
Hosts list sans deprecated ESX versions post fix

@miq-bot
Copy link
Member

miq-bot commented Aug 15, 2019

Checked commit GregP@daaa204 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@h-kataria h-kataria self-assigned this Aug 16, 2019
@h-kataria h-kataria added this to the Sprint 118 Ending Aug 19, 2019 milestone Aug 16, 2019
@h-kataria h-kataria merged commit ab618c5 into ManageIQ:master Aug 16, 2019
simaishi pushed a commit that referenced this pull request Nov 1, 2019
@simaishi
Copy link
Contributor

simaishi commented Nov 1, 2019

Ivanchuk backport details:

$ git log -1
commit 3c4972d1b29e0e87632be78f30ed408b065c87ed
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Thu Aug 15 23:03:31 2019 -0400

    Merge pull request #19159 from GregP/remove_deprecated_host_esx_versions
    
    Remove deprecated VMWare Hosts
    
    (cherry picked from commit ab618c559cead3a0d6de3f7048b1865acb01b46c)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants