Add support to Embedded Ansible for ssh user@host:path urls #19129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit Fryguy@4019f7e with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
NickLaMuro
reviewed
Aug 9, 2019
| @@ -9,7 +9,7 @@ class GitRepository < ApplicationRecord | |||
|
|
|||
| attr_reader :git_lock | |||
|
|
|||
| validates :url, :format => URI.regexp(%w[http https file ssh]), :allow_nil => false | |||
| validates :url, :format => Regexp.union(URI.regexp(%w[http https file ssh]), /\A[-\w:.]+@.*:/), :allow_nil => false | |||
There was a problem hiding this comment.
Should our custom regexp:
/\A[-\w:.]+@.*:/Be a constant so that we can reference it else where? For parsing out user/pass/etc. later?
carbonin
approved these changes
Aug 9, 2019
simaishi
pushed a commit
that referenced
this pull request
Aug 9, 2019
Add support to Embedded Ansible for ssh user@host:path urls (cherry picked from commit 11ad9b8)
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@carbonin @NickLaMuro Please review.
This is using the same regex that the UI uses [1], since I couldn't find a "standard" one.
[1] https://github.com/ManageIQ/manageiq-ui-classic/blob/e737cc675ee006c11508bc23f038c3357a1fb089/app/assets/javascripts/directives/url_validation.js#L21