Make embedded ansible verbosity and execution_ttl work #18989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLaMuro
reviewed
Jul 16, 2019
carbonin
force-pushed
the
add_more_options_to_ansible_stuff
branch
2 times, most recently
from
5b9bb52
to
7ff2557
Compare
NickLaMuro
approved these changes
Jul 17, 2019
carbonin
changed the title
carbonin
force-pushed
the
add_more_options_to_ansible_stuff
branch
from
f410e3c
to
6473b88
Compare
Fryguy
reviewed
Jul 18, 2019
|
|
||
| response = Ansible::Runner.run_async(env_vars, extra_vars, playbook_path, :hosts => hosts, :credentials => credentials) | ||
| response = Ansible::Runner.run_async(env_vars, extra_vars, playbook_path, :hosts => hosts, :credentials => credentials, :verbosity => verbosity) |
There was a problem hiding this comment.
You might be able to get slightly tighter code here with something like
env_vars, extra_vars, playbook_path = options.values_at(:env_vars, :extra_vars, :playbook_path)
kw_args = options.slice(:credentials, :hosts, :verbosity)
response = Ansible::Runner.run_async(env_vars, extra_vars, playbook_path, kw_args)There was a problem hiding this comment.
Fryguy
reviewed
Jul 18, 2019
Fryguy
reviewed
Jul 18, 2019
Previously this option was being ignored and the job timeout was always the default of 1.hour
carbonin
force-pushed
the
add_more_options_to_ansible_stuff
branch
from
6473b88
to
6d4d78c
Compare
carbonin
force-pushed
the
add_more_options_to_ansible_stuff
branch
from
6d4d78c
to
40f33b0
Compare
|
Checked commits carbonin/manageiq@409c322~...40f33b0 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 lib/ansible/runner.rb
|
Fryguy
reviewed
Jul 18, 2019
| network_credential_id | ||
| cloud_credential_id | ||
| vault_credential_id | ||
| verbosity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds what is needed to
Ansible::Runnerto get verbosity working correctly and also passes the option down from services and automate.The PR also configures the
AnsiblePlaybookWorkflowtimeout using theexecution_ttlfrom the service.This seems to have been completed for playbook automate methods (albeit slightly differently) in #17476
cc @NickLaMuro @Fryguy @bzwei @tinaafitz