[V2V] Filter certain options in the ConversionHost#run_conversion method #18852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label transformation, hammer/yes, changelog/yes |
bdunne
reviewed
Jun 13, 2019
bdunne
reviewed
Jun 14, 2019
| def run_conversion(conversion_options) | ||
| ignore = %w[password fingerprint key] | ||
| filtered_options = conversion_options.clone.tap { |h| h.each { |k, _v| h[k] = "__FILTERED__" if ignore.any? { |i| k.to_s.end_with?(i) } } } |
There was a problem hiding this comment.
What do you think of this?
filtered_options = conversion_options.each_with_object({}) { |(k, v), h| h[k] = (k.to_s =~ /(fingerprint|key|password)\z/) ? "__FILTERED__" : v }There was a problem hiding this comment.
Looks more difficult than mine. I'm sure there are multiple ways to skin a cat here, but I'd like to keep mine unless you have strong objections.
Replace sensitive values with FILTERED, and remove unnecessary variable assignment.
|
Checked commit https://github.com/djberg96/manageiq/commit/a2948baf526df31fbdc4c360e000fb43d06fe938 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jun 14, 2019
…ering [V2V] Filter certain options in the ConversionHost#run_conversion method (cherry picked from commit 11c18ab) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1720756
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the
ConversionHost#run_conversionmethod potentially exposes some sensitive data on failure. This PR filters anything that ends with "password", "key" or "fingerprint" from the logs and/or UI.BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1716415