Update a service's lifecycle_state. #18803

lfu · 2019-05-23T18:06:31Z

Add lifecycle_state column to services to record a service's provision state. May be extended to the full lifecycle which contains provision, reconfigure and retirement.

Depends on ManageIQ/manageiq-schema#374.
https://bugzilla.redhat.com/show_bug.cgi?id=1677571

@miq-bot assign @tinaafitz
@miq-bot add_label enhancement, changelog/yes, services

bdunne · 2019-06-03T15:17:20Z

Are you going to deprecate_attribute in case there are other callers to the renamed column?

lfu · 2019-06-03T15:59:06Z

The renamed column was recently added in ManageIQ/manageiq-schema#356.
There isn't any usage yet.

tinaafitz · 2019-06-05T21:01:18Z

app/models/mixins/lifecycle_mixin.rb

+  end
+
+  def provisioned?
+    lifecycle_state == 'provisioned'


@lfu Would it make sense to have the states as constants and freeze them? (provisioning, provisioned, error_provisioned)

tinaafitz · 2019-06-05T21:03:53Z

app/models/service.rb

@@ -88,6 +89,7 @@ class Service < ApplicationRecord
  default_value_for :display, false
  default_value_for :retired, false
  default_value_for :initiator, 'user'
+  default_value_for :lifecycle_state, 'unprovisioned'


@lfu I know we discussed using 'unprovisioned', but I'm wondering if there is another value we could use here?
@mkanoor Thoughts?

tinaafitz · 2019-06-05T21:07:22Z

spec/models/service_template_provision_task_spec.rb

+        expect(@service.lifecycle_state).to eq('provisioned')
+      end
+
+      it 'set servcie lifecycle_state to error_provisioned' do


@lfu same here.

mkanoor · 2019-06-05T21:15:38Z

app/models/mixins/lifecycle_mixin.rb

+  def update_lifecycle_state
+    case miq_request.request_state
+    when "finished"
+      lifecycle_state = miq_request.status == 'Ok' ? "provisioned" : "error_provisioned"


@lfu should error_provisioned be error_in_provisioning? or can it be just error

@mkanoor We had a meeting with @Fryguy where we discussed possibly using the lifecycle_state for retirement in the future, so we're trying to use 'provision' in the state where possible.

I will take error_in_provisioning to support retirement in the future.

tinaafitz · 2019-06-05T21:15:48Z

spec/models/service_template_provision_task_spec.rb

+        expect(@service.lifecycle_state).to eq('provisioning')
+      end
+
+      it 'set servcie lifecycle_state to provisioned' do


@lfu Can you fix the typo for "set servcie"

Fryguy · 2019-06-10T18:34:42Z

@lfu Dependent schema PR is merged.

mkanoor · 2019-06-19T15:41:12Z

spec/models/service_template_provision_task_spec.rb

+        @task_0.destination = @service
+        @request.miq_request_tasks.except(@task_0).each { |t| t.update(:state => "finished") }
+        @task_0.update_and_notify_parent(:state => "finished", :status => "Ok", :message => "Test Message")
+        expect(@service.lifecycle_state).to eq(Service::STATE_PROVISIONED)


@lfu should this just use the helper method provisioned? ?

mkanoor · 2019-06-19T15:41:50Z

spec/models/service_template_provision_task_spec.rb

+        @task_0.destination = @service
+        @request.miq_request_tasks.except(@task_0).each { |t| t.update(:state => "finished") }
+        @task_0.update_and_notify_parent(:state => "finished", :status => "Error", :message => "Test Message")
+        expect(@service.lifecycle_state).to eq(Service::STATE_ERROR_PROVISIONING)


@lfu this could use the provision_failed? method

bdunne · 2019-06-20T14:48:55Z

spec/models/service_template_provision_task_spec.rb

@@ -258,6 +258,30 @@ def service_resource_id(index, scaling_max)
        @task_1_2.destination = @service
        @task_1_2.update_and_notify_parent(:state => "finished", :status => "Ok", :message => "Test Message")
      end
+
+      it 'set service lifecycle_state to provisioning' do
+        zone                = FactoryBot.create(:zone, :name => "service_template_zone")


Please don't set zone name, it is sequenced by the factory

bdunne · 2019-06-20T14:51:39Z

spec/models/service_template_provision_task_spec.rb

+
+      it 'set service lifecycle_state to provisioning' do
+        zone                = FactoryBot.create(:zone, :name => "service_template_zone")
+        @task_3.source      = FactoryBot.create(:service_template, :zone => zone)


Do you need to set zone here?

https://bugzilla.redhat.com/show_bug.cgi?id=1677571

miq-bot · 2019-06-20T15:01:38Z

Checked commit lfu@da1c436 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 0 offenses detected
Everything looks fine. 👍

lfu mentioned this pull request May 23, 2019

Rename service state to lifecycle_state. ManageIQ/manageiq-schema#374

Merged

miq-bot assigned tinaafitz May 23, 2019

miq-bot added changelog/yes enhancement lifecycle/services labels May 23, 2019

tinaafitz reviewed Jun 5, 2019

View reviewed changes

mkanoor reviewed Jun 5, 2019

View reviewed changes

tinaafitz reviewed Jun 5, 2019

View reviewed changes

lfu force-pushed the rename_service_state_1677571 branch from 7ea19a1 to f7cf34e Compare June 6, 2019 20:59

Fryguy closed this Jun 10, 2019

Fryguy reopened this Jun 10, 2019

lfu force-pushed the rename_service_state_1677571 branch from f7cf34e to e53acfc Compare June 19, 2019 11:45

mkanoor reviewed Jun 19, 2019

View reviewed changes

lfu force-pushed the rename_service_state_1677571 branch from e53acfc to 747f636 Compare June 20, 2019 14:28

bdunne reviewed Jun 20, 2019

View reviewed changes

Update a service's lifecycle_state.

da1c436

https://bugzilla.redhat.com/show_bug.cgi?id=1677571

lfu force-pushed the rename_service_state_1677571 branch from 747f636 to da1c436 Compare June 20, 2019 14:54

mkanoor approved these changes Jun 21, 2019

View reviewed changes

bdunne merged commit fff2760 into ManageIQ:master Jun 21, 2019

bdunne assigned bdunne and unassigned tinaafitz Jun 21, 2019

bdunne added this to the Sprint 114 Ending Jun 24, 2019 milestone Jun 21, 2019

bdunne added the hammer/no label Jun 21, 2019

lfu deleted the rename_service_state_1677571 branch July 29, 2019 19:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update a service's lifecycle_state. #18803

Update a service's lifecycle_state. #18803

lfu commented May 23, 2019

bdunne commented Jun 3, 2019

lfu commented Jun 3, 2019

tinaafitz Jun 5, 2019

tinaafitz Jun 5, 2019

tinaafitz Jun 5, 2019 •

edited

Loading

mkanoor Jun 5, 2019

tinaafitz Jun 5, 2019

lfu Jun 6, 2019

tinaafitz Jun 5, 2019 •

edited

Loading

Fryguy commented Jun 10, 2019

mkanoor Jun 19, 2019

mkanoor Jun 19, 2019

bdunne Jun 20, 2019

bdunne Jun 20, 2019

miq-bot commented Jun 20, 2019

Update a service's lifecycle_state. #18803

Update a service's lifecycle_state. #18803

Conversation

lfu commented May 23, 2019

bdunne commented Jun 3, 2019

lfu commented Jun 3, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tinaafitz Jun 5, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tinaafitz Jun 5, 2019 • edited Loading

Choose a reason for hiding this comment

Fryguy commented Jun 10, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miq-bot commented Jun 20, 2019

tinaafitz Jun 5, 2019 •

edited

Loading

tinaafitz Jun 5, 2019 •

edited

Loading