Allow textarea boxes to dynamically set validator type and rule #18743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eclarizio Can you please change the BZ reference in the git commit message to https://bugzilla.redhat.com/show_bug.cgi?id=1694737 so 5.10.z clone https://bugzilla.redhat.com/show_bug.cgi?id=1702064 won't move to POST after PR is merged. |
tinaafitz
approved these changes
May 7, 2019
eclarizio
force-pushed
the
allow_textarea_dynamic_attributes
branch
from
92a059d
to
f761aa3
Compare
|
@simaishi Sure, updated! |
|
Checked commit eclarizio@f761aa3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
mkanoor
approved these changes
May 7, 2019
simaishi
pushed a commit
that referenced
this pull request
May 8, 2019
…butes Allow textarea boxes to dynamically set validator type and rule (cherry picked from commit 5bd2a9e) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702064
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only regular text boxes can set their regex validations dynamically, but the below linked BZ was specifically testing with textarea boxes and thus wasn't getting the benefit of dynamic validation rule setting.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1694737
@miq-bot add_label bug, hammer/yes
@miq-bot assign @tinaafitz