Group AND expressions properly to account for nesting #18709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
force-pushed
the
fixing_arel_node_grouping_for_and
branch
from
1a8923e
to
d995e4d
Compare
d-m-u
force-pushed
the
fixing_arel_node_grouping_for_and
branch
from
d995e4d
to
8875a22
Compare
|
Checked commit d-m-u@8875a22 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label changelog/yes |
jrafanie
approved these changes
May 1, 2019
There was a problem hiding this comment.
LGTM, I worked with @d-m-u on this... @gtanzillo do you have any concern with doing this? It fixes an issue where we were not properly grouping the AND atoms in "A OR B AND C" by always grouping AND expressions. I think this is extra caution but shouldn't break anything if we do needless extra grouping, right?
parens are our friends
simaishi
pushed a commit
that referenced
this pull request
Jun 14, 2019
Group AND expressions properly to account for nesting (cherry picked from commit 5c506fd) https://bugzilla.redhat.com/show_bug.cgi?id=1720753
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sql generated for a nested expression à la
c OR(a AND b)is incorrect because we're not wrapping the inside expression when it's anAND. This just adds the wrapping to all ANDs. It results in extra parens in a couple cases but while not having the parens is occasionally detrimental, having too many is never going to hurt us so we should err on the side of too many, methinks.Fixes part of https://bugzilla.redhat.com/show_bug.cgi?id=1660460
It'll require UI changes as well because https://bugzilla.redhat.com/show_bug.cgi?id=1660460#c8 is still an issue