Retirement - remove auto_approve flag on request creation. #18638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
request before the Automate auto approval state machine. Removing the auto_approve flag allows users to change the approval type in Automate.
tinaafitz
changed the title
|
Checked commit tinaafitz@b035ee4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label bug, hammer/yes |
tinaafitz
changed the title
|
@d-m-u @gmcculloug Please review. |
|
I think there's a test for orch_stacks that maybe needs updating? |
gmcculloug
approved these changes
Apr 8, 2019
|
@d-m-u There is a spec test for orch stacks retirement, but it doesn't check for the auto-approve parameter. |
d-m-u
approved these changes
Apr 8, 2019
simaishi
pushed a commit
that referenced
this pull request
Apr 22, 2019
Retirement - remove auto_approve flag on request creation. (cherry picked from commit 0d66d43) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702075
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make_retire_request was setting auto_approve to true which approves the request before the Automate auto approval state machine. Removing the auto_approve flag allows users to change the approval type in Automate.
Before the Retirement as a request enhancement, users would be able to stop/delay retirement by modifying the Automate state machine. In order to stop/delay Retirement with retirement as a request, users will need to be able to prevent the request from being approved, either by denying it, or setting the approval type to manual. The code change in this PR will give them the ability to do that.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1697600