Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dup should just dup and not save... #18490

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Dup should just dup and not save... #18490

merged 1 commit into from
Feb 26, 2019

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Feb 26, 2019

Per post-merge review #18464 (comment), overriding dup shouldn't save the object, only dup it, so this shouldn't be an update_attrs.

@d-m-u
Copy link
Contributor Author

d-m-u commented Feb 26, 2019

@miq-bot assign @bdunne
@miq-bot add_label hammer/no

@d-m-u d-m-u mentioned this pull request Feb 26, 2019
Merged
bdunne
bdunne approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks

@miq-bot
Copy link
Member

miq-bot commented Feb 26, 2019

Checked commit d-m-u@e9db7b5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@bdunne bdunne merged commit 3670332 into ManageIQ:master Feb 26, 2019
@bdunne bdunne added this to the Sprint 106 Ending Mar 4, 2019 milestone Feb 26, 2019
@d-m-u d-m-u deleted the fixing_service_template_dup_to_act_like_dup branch February 26, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne approved these changes

Assignees

@bdunne bdunne

Labels
hammer/no
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-m-u @miq-bot @bdunne