Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targeted refresh for Embedded ansible provider #18429

Merged
merged 3 commits into from
Feb 11, 2019

Conversation

slemrmartin
Copy link
Contributor

@slemrmartin slemrmartin commented Feb 4, 2019

Targeted refresh for refreshing only specified inventory (and its subgraph) - like for amazon, azure etc.

Based on Targeted refresh support for AnsibleTower.


Also merging of ^^ will cause spec error in core repo (because of bad core -> tower dependency and shared specs)

@slemrmartin
Copy link
Contributor Author

cc @agrare

@slemrmartin slemrmartin changed the title Targeted refresh for Embedded ansible provider [WIP] Targeted refresh for Embedded ansible provider Feb 6, 2019
@slemrmartin slemrmartin changed the title [WIP] Targeted refresh for Embedded ansible provider Targeted refresh for Embedded ansible provider Feb 6, 2019
@slemrmartin
Copy link
Contributor Author

@Ladas

Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Ladas
Copy link
Contributor

Ladas commented Feb 6, 2019

@miq-bot assign @agrare

@agrare agrare closed this Feb 6, 2019
@agrare agrare reopened this Feb 6, 2019
@agrare
Copy link
Member

agrare commented Feb 6, 2019

@slemrmartin looks like core tests are still failing after merging the ansible_tower PR, can you take a look?

@agrare agrare force-pushed the embedded-ansible-targeted-refresh branch from dc11f05 to bc92d67 Compare February 6, 2019 17:37
@slemrmartin
Copy link
Contributor Author

hm, I think that's namespace problem, it probably tries to find AnsibleTower object instead of EmbeddedAnsible. The worse is that I solved it yesterday and specs are ok on dev, so CI is working differently in some unknown way. I'll think about it

Failing only in CI and CI depends on AnsibleTower PR
@slemrmartin
Copy link
Contributor Author

@agrare I cannot reproduce it and cannot re-run CI, so I don't know, I believe it's mainly problem of spec, not with refresh itself (the same code with the same spec works for ansible tower), so as @Ladas pointed out, it could be merged without the spec (both PRs) and then I'll have possibilities to test it on travis

@agrare
Copy link
Member

agrare commented Feb 11, 2019

@slemrmartin that seemed to work, lets add back the specs now

@slemrmartin
Copy link
Contributor Author

@agrare it's not working for ruby 2.5

@agrare
Copy link
Member

agrare commented Feb 11, 2019

The issue with the VCRs not matching right?

@slemrmartin
Copy link
Contributor Author

slemrmartin commented Feb 11, 2019

cc @agrare @bdunne - I found one problem with ruby 2.5 VCR cassettes errors.
It tries to GET https://dev-ansible-tower3.example.com/api/v1/project_updates/422// (see two slashes at the end) -
this is caused by

where find(related['last_update']) == "project_updates//api/v1/project_updates/422//"

It's somehow fixed by ruby 2.4, but not by 2.5

@slemrmartin
Copy link
Contributor Author

@slemrmartin slemrmartin deleted the embedded-ansible-targeted-refresh branch February 11, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants