Add uri_attributes as virtual_attribute to CustomButton #18379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit ZitaNemeckova@a219396 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@lpichler please review :) |
|
Does it need specs? |
|
@djberg96 I believe not for this PR because mechanism of virtual attributes have specs already. But @ZitaNemeckova you can somehow extend specs in API and add case for exposing this method. |
|
@miq-bot assign @gtanzillo |
|
LGTM, we should add the tests in the api when we expose uri_attributes via the api though as @lpichler mentioned |
jrafanie
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ManageIQ/manageiq-ui-classic#5166 that fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650559
I need API to give me
uri_attributesto get relevant data forCustomButtonwithbutton_type = "ansible_playbook". So this PR adds it tovirtual_attribute.@lpichler please have a look :)
@miq-bot add_label bug, gaprindashvili/yes, hammer/yes, api, automate