Rails 5.0/5.1 compatibility: Define through association before has many through #18080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to 85c0224, we want the cascading delete to avoid orphaned resources, so we'll remove the one that doesn't explicitly say dependent => destroy. Rails 5.1+ complains about has_many through associations if the through association is not yet defined, and in this case, the second host_storages association occurs after the through association, so rails yells: ``` ActiveRecord::HasManyThroughOrderError: Cannot have a has_many :through association 'Storage#hosts' which goes through 'Storage#host_storages' before the through association is defined. ``` Extracted from ManageIQ#18076
Rails 5.1+ complains about has_many through associations if the through association is not yet defined. Extracted from ManageIQ#18076
NickLaMuro
suggested changes
Oct 10, 2018
| @@ -18,7 +18,6 @@ class Storage < ApplicationRecord | |||
| has_many :storage_files, :dependent => :destroy | |||
| has_many :storage_files_files, -> { where("rsc_type = 'file'") }, :class_name => "StorageFile", :foreign_key => "storage_id" | |||
| has_many :files, -> { where("rsc_type = 'file'") }, :class_name => "StorageFile", :foreign_key => "storage_id" | |||
| has_many :host_storages | |||
There was a problem hiding this comment.
What is this doing here? Seems unrelated to the original PR.
There was a problem hiding this comment.
Sorry, let me explain. There's two host_storages has_manys. One on line line 5 and one here, at line 21. Because this one on line 21 is "last", it wins. This causes a problem because line 6, we have:
has_many :hosts, :through => :host_storages
This causes complaints on rails 5.1 because the through association is needed before it's defined.
|
Checked commits jrafanie/manageiq@6ce9a5c~...6423d74 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
jrafanie
deleted the
rails_5_1_define_through_association_before_has_many_through
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5.1+ complains about has_many through associations if the through
association is not yet defined.
Extracted from #18076