Currently on a successful ActionResult (start / stop) we return nil #18036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonin
reviewed
Oct 1, 2018
| @@ -231,24 +231,24 @@ def expect_api_call(expected_action, expected_args = nil) | |||
| it "calls the given action with the given args" do | |||
| args = {:my => "args", :here => 123} | |||
| expect(api_collection).to receive(action).with(args).and_return(api_success_result) | |||
| described_class.exec_api_call(region, collection_name, action, args) | |||
| expect(described_class.exec_api_call(region, collection_name, action, args)).to be(api_success_result) | |||
There was a problem hiding this comment.
Should this be .to eq? I'm not sure what this syntax actually does.
There was a problem hiding this comment.
¯\_(ツ)_/¯ since it's stubbed, it will be the same object id.
carbonin
reviewed
Oct 1, 2018
| @@ -77,6 +77,7 @@ def self.exec_api_call(region, collection_name, action, api_args = nil, id = nil | |||
| case result | |||
| when ManageIQ::API::Client::ActionResult | |||
| raise InterRegionApiMethodRelayError, result.message if result.failed? | |||
| result | |||
There was a problem hiding this comment.
Is there something better in the action result that we can return? Or maybe just true would be better to indicate a successful API call?
There was a problem hiding this comment.
I'm thinking it should be the JSON response from the remote region API. What do you think?
There was a problem hiding this comment.
What does that actually look like in this case? Could you post an example?
I agree that it's better than the result object itself.
There was a problem hiding this comment.
Okay, updated the PR accordingly and the output is:
irb(main):003:0> r = vm.stop({})
=> #<ManageIQ::API::Client::ActionResult:0x0000000009d66010 @attributes={"success"=>true, "message"=>"VM id:1 name:'something' stopping", "task_id"=>"4", "task_href"=>"https://x.x.x.x/api/tasks/4", "href"=>"https://x.x.x.x/api/vms/1"}>
irb(main):004:0> r.attributes
=> {"success"=>true, "message"=>"VM id:1 name:'something' stopping", "task_id"=>"4", "task_href"=>"https://x.x.x.x/api/tasks/4", "href"=>"https://x.x.x.x/api/vms/1"}Returning the result of the api call would at least be a positive result https://bugzilla.redhat.com/show_bug.cgi?id=1628658
bdunne
force-pushed
the
action_result_shouldnt_be_nil
branch
from
4b81358
to
d5c75ad
Compare
|
Checked commit bdunne@d5c75ad with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Oct 2, 2018
Currently on a successful ActionResult (start / stop) we return nil (cherry picked from commit 2fb6260) https://bugzilla.redhat.com/show_bug.cgi?id=1628658
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
Oct 10, 2018
Currently on a successful ActionResult (start / stop) we return nil (cherry picked from commit 2fb6260) https://bugzilla.redhat.com/show_bug.cgi?id=1635764
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning the result of the api call would at least be a positive result
https://bugzilla.redhat.com/show_bug.cgi?id=1628658