Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex for dialog password fields. #17986

Merged
merged 1 commit into from
Sep 13, 2018

Conversation

lfu
Copy link
Member

@lfu lfu commented Sep 13, 2018

To hide the password value in evm.log like these:

[----] I, [2018-09-04T11:52:30.068959 #12301:c27108]  INFO -- : Q-task_id([miq_provision_3]) MIQ(ManageIQ::Providers::Vmware::InfraManager::Provision#log_clone_options) Prov Options: [:"password::password_field"](String) = "v2:{SEZAjnaOSeyzt387/rAooQ==}"
[----] I, [2018-09-04T11:52:30.069053 #12301:c27108]  INFO -- : Q-task_id([miq_provision_3]) MIQ(ManageIQ::Providers::Vmware::InfraManager::Provision#log_clone_options) Prov Options: [:"password::dialog_password_field"](String) = "v2:{SEZAjnaOSeyzt387/rAooQ==}"

Part of ManageIQ/manageiq-automation_engine#228.

https://bugzilla.redhat.com/show_bug.cgi?id=1619385

@miq-bot assign @gmcculloug
@miq-bot add_label bug, gaprindashvili/yes, automate

@miq-bot
Copy link
Member

miq-bot commented Sep 13, 2018

Checked commit lfu@2247c8a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@gmcculloug gmcculloug merged commit cadcbc7 into ManageIQ:master Sep 13, 2018
@gmcculloug gmcculloug added this to the Sprint 95 Ending Sep 24, 2018 milestone Sep 13, 2018
@JPrause
Copy link
Member

JPrause commented Sep 14, 2018

@miq-bot add_label blocker

@lfu lfu deleted the password_log_1619385 branch September 29, 2018 14:31
simaishi pushed a commit that referenced this pull request Oct 1, 2018
@simaishi
Copy link
Contributor

simaishi commented Oct 1, 2018

Gaprindashvili backport details:

$ git log -1
commit 043a181fe873034556cd0783bef4e71ab8d0e8fa
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Thu Sep 13 17:16:52 2018 -0400

    Merge pull request #17986 from lfu/password_log_1619385
    
    Add regex for dialog password fields.
    
    (cherry picked from commit cadcbc726d83f8a6e87421f48aa0b1c8f0ccff46)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1634808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants