virtual column for default_security_group to make it accessible via the API
#17975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agrare Would you be able to review this? |
|
Checked commit AparnaKarve@0018e67 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Sep 11, 2018
|
@AparnaKarve @agrare hm, this is failing refresh because of a missing type. @kbrock can virtual_column be used for this? Since it returns an AR object, not sure what the type should be. Shouldn't this be |
|
@Ladas Both |
|
@AparnaKarve ok, I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
default_security_groupmethod forcloud_tenantswas added here - ManageIQ/manageiq-providers-openstack#347We need the virtual column for
default_security_groupso that it is accessible via the APIdefault_security_groupis a requirement for v2v OSP support.