Add Switch model to RBAC #17964
Merged
Add Switch model to RBAC #17964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
force-pushed
the
add_switch_and_lan_to_rbac
branch
from
705ec0e
to
a318d2f
Compare
gtanzillo
reviewed
Sep 10, 2018
lib/rbac/filterer.rb
Outdated
| @@ -34,6 +34,7 @@ class Filterer | |||
| FloatingIp | |||
| Host | |||
| HostAggregate | |||
| Lan | |||
There was a problem hiding this comment.
@lpichler Just checking - does the UI allow for tagging Lans? I'm having difficulty finding where they are visible, otherwise I'd check myself.
There was a problem hiding this comment.
you are right, there is no lan_controller in UI repo...so removing.
lpichler
force-pushed
the
add_switch_and_lan_to_rbac
branch
2 times, most recently
from
e497360
to
8f1a3ff
Compare
lpichler
force-pushed
the
add_switch_and_lan_to_rbac
branch
from
8f1a3ff
to
59aa33f
Compare
|
Checked commit lpichler@59aa33f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@gtanzillo CI is green here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probably missed as tagging has been added here #10493
Links
@miq-bot add_label bug, rbac
@miq-bot assign @gtanzillo