Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing definitions for targeted refresh for containers #17846

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Aug 11, 2018

Missing definitions for targeted refresh for containers

Missing definitions for targeted refresh for containers
@Ladas
Copy link
Contributor Author

Ladas commented Aug 11, 2018

@miq-bot assign @agrare
@miq-bot add_label enhancement

@Ladas
Copy link
Contributor Author

Ladas commented Aug 11, 2018

@agrare @gtanzillo so this is missing from core, for having OpenShift targeted persistor (and I think I've figured out how to actually autogenerate these)

@miq-bot
Copy link
Member

miq-bot commented Aug 11, 2018

Checked commit Ladas@7d1886e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

app/models/manager_refresh/inventory_collection/builder/container_manager.rb

Copy link
Contributor

@cben cben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
introspecting the parent_inventory_collections would be huge for simplicity

@agrare agrare merged commit a40054b into ManageIQ:master Aug 13, 2018
@agrare agrare added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants