Fix metering report for resources without rollups #17836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot gaprindashvili/yes |
|
@lpichler unrecognized command 'gaprindashvili', ignoring... Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
lpichler
force-pushed
the
fix_metering_report_without_rolups
branch
from
7d44c5c
to
486c3d3
Compare
|
Checked commit lpichler@486c3d3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label gaprindashvili/yes |
simaishi
pushed a commit
that referenced
this pull request
Sep 11, 2018
…olups Fix metering report for resources without rollups (cherry picked from commit b57f267) https://bugzilla.redhat.com/show_bug.cgi?id=1623563
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metering reports are for resources with rollups. But for SCVMM there is exception. Resource from SCVMM are also considered in metering reports even if that there are metric rollups used.
This fix is adding sum method to fix the error message.
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1595696
@miq-bot assign @gtanzillo
@miq-bot add_label chargeback, bug