Add Cumulative Chargeback rates #17795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
force-pushed
the
add_cumulative_chargeback_calculation
branch
5 times, most recently
from
bcc50b9
to
b403052
Compare
|
@miq-bot assign @gtanzillo @miq-bot add_label gaprindashvili/yes, blocker |
lpichler
changed the title
gtanzillo
approved these changes
Aug 3, 2018
| ) do | ||
| def self.new_from_h(hash) | ||
| new(*hash.values_at(*members)) | ||
| end | ||
|
|
||
| def skip_field_accumulation?(field, value) | ||
| return false unless cumulative_rate_calculation? |
There was a problem hiding this comment.
The unless here is a little confusing. Would you mind flipping these to return false if ...?
There was a problem hiding this comment.
sure I also added comment to bring clarity in this method.
thanks!
lpichler
force-pushed
the
add_cumulative_chargeback_calculation
branch
2 times, most recently
from
016b7d2
to
18e09f2
Compare
It is possible to assign chargeback rates to more tags from various tag categories (ManageIQ/manageiq-ui-classic#4310). It will cause costs for each rate will be added up. Example: VM has tag department/it and enviroment/test Rate 1 is assigned to tag department/it Rate 2 is assigned to tag enviroment/test Then if checkbox from (ManageIQ/manageiq-ui-classic#4310) will turn on it will add costs from Rate 1 and Rate 2 together. cost = Rate 1 + Rate 1 But metric value will not be doubled.
lpichler
force-pushed
the
add_cumulative_chargeback_calculation
branch
from
18e09f2
to
ccee53b
Compare
|
Checked commit lpichler@ccee53b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Aug 7, 2018
…culation Add Cumulative Chargeback rates (cherry picked from commit ae59274) https://bugzilla.redhat.com/show_bug.cgi?id=1613367
|
Gaprindashvili backport details: |
|
@lpichler Please take a look at Travis failure in G-branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cumulative calculation to chargeback for tagged resources
It is possible to assign chargeback rates to more tags from
various tag categories (ManageIQ/manageiq-ui-classic#4310).
It will cause costs for each rate will be added up.
Example:
VM has tag department/it and enviroment/test
Rate 1 is assigned to tag department/it
Rate 2 is assigned to tag enviroment/test
Then if checkbox from (ManageIQ/manageiq-ui-classic#4112)
will turn on it will add costs from Rate 1 and Rate 2
together.
cost = Rate 1 + Rate 1
But metric values are not affected.
This basically enabling optionally behaviour before #12534
Pictures
VM has tag
Auto Approve - Max CPU/1
Enviroment/Develompent
Rate for Auto Approve - Max CPU/1
Report Result
Rate for Enviroment/Development
Report Result
rate Enviroment Rate is assigned only to Enviroment/Development
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1584018