Add Ownership and Tenancy Mixins to Authentication #17731
Conversation
| include OwnershipMixin | ||
| include TenancyMixin | ||
|
|
||
| belongs_to :tenant |
There was a problem hiding this comment.
I wonder if we should move this into the TenancyMixin similar to how evm_owner and miq_group are in OwnershipMixin ref.
There was a problem hiding this comment.
I don't think so because there are some classes that include TenancyMixin that don't actually have a tenant_id
agrare
force-pushed
the
bz_1589766_add_owner_and_group_to_auth
branch
from
a8bfff2
to
1f86bb7
Compare
|
Gaprindashvili backport: #17732 |
agrare
force-pushed
the
bz_1589766_add_owner_and_group_to_auth
branch
from
1f86bb7
to
e1690e1
Compare
This adds ownership and tenancy to authentications allowing for key pairs added by EmsRefresh to be associated with users in manageiq. https://bugzilla.redhat.com/show_bug.cgi?id=1589766
agrare
force-pushed
the
bz_1589766_add_owner_and_group_to_auth
branch
from
e1690e1
to
4c6ba95
Compare
|
Checked commit agrare@4c6ba95 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
I already created a gaprindashvili backport PR
…On Thu, Jul 26, 2018 at 2:46 PM, John Prause ***@***.***> wrote:
@agrare if this can be backported, please add the gaprindashvili/yes
label.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@Ladas so could we set these during EmsRefresh if the parser returns the username? |
|
@agrare we should probably focus on manual assignment for now, plus assignment during creation. Manual and refresh assignment will probably not work together well, since they will be overwriting each other. |
|
@gtanzillo this is ready, can you take a look? |
|
@agrare @Ladas @gtanzillo Hi, this actually breaks OpenStack provider Travis [1]. Is there something we should change in OpenStack keypairs to make it compatible with Tenancy? [1] https://travis-ci.org/ManageIQ/manageiq-providers-openstack/jobs/430257732 |
|
This should fix the CIs #17998 |
This adds ownership and tenancy to authentications allowing for key
pairs added by EmsRefresh to be associated with users in manageiq.
Depends: ManageIQ/manageiq-schema#237
https://bugzilla.redhat.com/show_bug.cgi?id=1589766