Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class name for queueing #17717

Merged
merged 1 commit into from
Jul 17, 2018
Merged

Fix class name for queueing #17717

merged 1 commit into from
Jul 17, 2018

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jul 17, 2018

@bdunne bdunne requested review from gtanzillo and AllenBW July 17, 2018 15:07
@miq-bot
Copy link
Member

miq-bot commented Jul 17, 2018

Checked commit bdunne@27c1dbd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@gmcculloug gmcculloug self-assigned this Jul 17, 2018
gtanzillo
gtanzillo approved these changes Jul 17, 2018
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AllenBW AllenBW mentioned this pull request Jul 17, 2018
Closed
@AllenBW
Copy link
Member

AllenBW commented Jul 17, 2018

Jumping in, seeing what it does 👀

@gmcculloug gmcculloug merged commit 450a9a0 into ManageIQ:master Jul 17, 2018
@gmcculloug gmcculloug added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 17, 2018
@bdunne bdunne deleted the fix_class_name branch July 17, 2018 15:42
@simaishi
Copy link
Contributor

@bdunne #17594 isn't in Gaprindashvili branch. Does the change need to be made somewhere else, or is this not an issue in G-branch?

@gmcculloug
Copy link
Member

@bdunne I believe this supports v2v scheduling. If so please add the transformation label.

@bdunne bdunne added the v2v label Jul 25, 2018
@bdunne
Copy link
Member Author

bdunne commented Jul 25, 2018

@simaishi yes, #17594 also needs to go back.
@gmcculloug v2v == transformation? 😭

@gmcculloug
Copy link
Member

Yeah, I totally get that. The transformation label is meant to cover more then just v2v. For example p2v or virtual to cloud. But your objection is noted.

simaishi pushed a commit that referenced this pull request Jul 26, 2018
@gmcculloug @simaishi
Merge pull request #17717 from bdunne/fix_class_name
b64a0b3 
Fix class name for queueing
(cherry picked from commit 450a9a0)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1603057
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit b64a0b31a922b24669e900a8562a29bfcfe7f47d
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Tue Jul 17 11:38:48 2018 -0400

    Merge pull request #17717 from bdunne/fix_class_name
    
    Fix class name for queueing
    (cherry picked from commit 450a9a0c404be175eb33cf1641f42cbc5c14ba02)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1603057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

@AllenBW AllenBW Awaiting requested review from AllenBW

Assignees

@gmcculloug gmcculloug

Labels
blocker bug gaprindashvili/backported lifecycle/provisioning v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bdunne @miq-bot @AllenBW @simaishi @gmcculloug @gtanzillo