Remove generic object from all related services before destroy #17679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
gmcculloug
reviewed
Jul 9, 2018
app/models/generic_object.rb
Outdated
| @@ -200,4 +201,10 @@ def _call_automate(method_name, *args) | |||
| ws = MiqAeEngine.deliver(options) | |||
| ws.root['method_result'] | |||
| end | |||
|
|
|||
| def remove_go_from_all_related_services | |||
| ServiceResource.where(:resource_id => id).each do |resource| | |||
There was a problem hiding this comment.
Use :resource => self. The resource association is polymorphic, if any other object type happens to share the same ID as this generic object you would delete it. 😱
There was a problem hiding this comment.
@gmcculloug changed. Thanks
gmcculloug
reviewed
Jul 9, 2018
app/models/generic_object.rb
Outdated
|
|
||
| def remove_go_from_all_related_services | ||
| ServiceResource.where(:resource => self).each do |resource| | ||
| remove_from_service(Service.find_by(:id => resource.service_id)) |
There was a problem hiding this comment.
You do not have to lookup the service as it is an association of the resource object. Also, I am not sure if we need to protect if resource.service is nil but in case:
remove_from_service(resource.service)) if resource.service
|
LTGM other than the only comment GM made. |
|
Checked commits pkomanek/manageiq@06cb29e~...9e1380e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
pkomanek
deleted the
remove_generic_object_from_all_related_services_before_destroy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling the
generic_objectsmethod from theservicemodel returns array of GenericObjects and nils(for allready destroyed objects), which makes some UI crashes. So we decided to remove a GO from all related services in the#before_destroycallback. This PR is based on the BZ bellow.Links [Optional]
https://bugzilla.redhat.com/show_bug.cgi?id=1595149