Add relationship between [physical switch and physical chassis] and event stream #17661
Conversation
felipedf
force-pushed
the
switch_event
branch
3 times, most recently
from
304590a
to
7b963b6
Compare
felipedf
changed the title
felipedf
changed the title
|
Checked commit felipedf@4dc96ee with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
| @@ -27,6 +27,8 @@ class EventStream < ApplicationRecord | |||
|
|
|||
| belongs_to :middleware_server, :foreign_key => :middleware_server_id | |||
| belongs_to :physical_server | |||
| belongs_to :physical_chassis, :inverse_of => :event_streams | |||
| belongs_to :physical_switch, :inverse_of => :event_streams | |||
There was a problem hiding this comment.
I think I'm missing something here.
I didn't find physical_switch_id or physical_chassis_id in event_streams table.
Is it through physical_server?
(Not sure how many fields we can add to event_streams without things going seriously downhill)
There was a problem hiding this comment.
My bad here @kbrock, it is depended on another PR, added it to the description
There was a problem hiding this comment.
(Not sure how many fields we can add to event_streams without things going seriously downhill)
Agree, I guess it was decided to keep things this way while we design a better architecture for events.
@agrare am I right?
There was a problem hiding this comment.
Yeah the proposed solution was worse than the problem IMO and if this really becomes an issue we can always delete the middleware relationship keys.
|
ManageIQ/manageiq-schema#229 Merged |
| @@ -1,10 +1,14 @@ | |||
| class PhysicalChassis < ApplicationRecord | |||
| include SupportsFeatureMixin | |||
There was a problem hiding this comment.
Is this related to adding the relationship to ems_events?
There was a problem hiding this comment.
It is, as EventMixin tries to execute some method from SupportsFeatureMixin on its super class, in that context PhysicalChassis
https://github.com/ManageIQ/manageiq/blob/master/app/models/mixins/event_mixin.rb#L6
| @@ -1,10 +1,14 @@ | |||
| class PhysicalSwitch < Switch | |||
| include SupportsFeatureMixin | |||
This PR is able to add a relationship between
physical_switch-event_streamandphysical_chassis-event_streamDepends on:
ManageIQ/manageiq-schema#229