Give embedded ansible enough time to start in containers #17603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonin
force-pushed
the
add_ansible_container_timeout
branch
from
69e29be
to
c912989
Compare
Previously we would wait forever. That's never good. https://bugzilla.redhat.com/show_bug.cgi?id=1576744
We already do health checks from the EmbeddedAnsibleWorker so we don't really need OpenShift to do more, especially if they have small built-in timeouts. https://bugzilla.redhat.com/show_bug.cgi?id=1576744
carbonin
force-pushed
the
add_ansible_container_timeout
branch
from
c912989
to
572f295
Compare
|
Checked commits carbonin/manageiq@2a766b2~...572f295 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the health checks from ContainerEmbeddedAnsible and also adds a configurable timeout to the startup process of both
ContainerEmbeddedAnsibleandDockerEmbeddedAnsibleWe already do health checks from the EmbeddedAnsibleWorker so we don't really need OpenShift to do more.
https://bugzilla.redhat.com/show_bug.cgi?id=1576744