Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RBAC feature for Migration (v2v). #17596

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Jun 15, 2018

To be used together with the v2v PR: ManageIQ/manageiq-v2v#417

Problem: to make Migration work API access is needed. For that API other features need to be enabled. I don't know what those features are. This is something that probably needs to be documented so that the users don't get confused.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1585644

Before

rbac-migration-old

After

rbac-migration-new

@miq-bot
Copy link
Member

miq-bot commented Jun 15, 2018

Checked commit martinpovolny@f25eecc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@martinpovolny martinpovolny changed the title [WIP] Add RBAC feature for Migration (v2v). Add RBAC feature for Migration (v2v). Jun 15, 2018
@miq-bot miq-bot removed the wip label Jun 15, 2018
@martinpovolny
Copy link
Member Author

Ping @mzazrivec, @dclarizio, @h-kataria : I usually review these so I don't know whom to ask to review this one ;-) Can you take a look, please?

@dclarizio dclarizio requested a review from h-kataria June 18, 2018 15:54
@dclarizio dclarizio self-assigned this Jun 18, 2018
@dclarizio dclarizio merged commit 900fdc4 into ManageIQ:master Jun 19, 2018
@dclarizio dclarizio added this to the Sprint 89 Ending Jul 2, 2018 milestone Jun 19, 2018
@martinpovolny
Copy link
Member Author

martinpovolny commented Jun 19, 2018

This should go to Gaprindashvili (with the v2v counterpart).

@JPrause
Copy link
Member

JPrause commented Jun 25, 2018

@miq-bot add_label blocker

simaishi pushed a commit that referenced this pull request Jul 11, 2018
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit c514287aed82b5bafc3e4d00c8b84d23b6c1e979
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Tue Jun 19 07:35:25 2018 -0700

    Merge pull request #17596 from martinpovolny/migration_feature
    
    Add RBAC feature for Migration (v2v).
    (cherry picked from commit 900fdc46eab04f351366896d4d1c0309d3017977)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1595413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants