Add delete notifications for Networks, Subnets #17556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
This pull request is not mergeable. Please rebase and repush. |
andyvesel
force-pushed
the
add_notifications_for_subnets_networks
branch
from
9c6ad31
to
132fe2a
Compare
andyvesel
force-pushed
the
add_notifications_for_subnets_networks
branch
from
132fe2a
to
7e09b39
Compare
|
Checked commit andyvesel@7e09b39 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@agrare Do you know who could review this? |
agrare
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
delete_successanddelete_errornotification types for Cloud Networks and Cloud SubnetsRelevant BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1470210