Add option to clear classifications for tag_details #17465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgalis
force-pushed
the
add_option_to_clear_classifications
branch
from
6cceca6
to
e778bca
Compare
lgalis
force-pushed
the
add_option_to_clear_classifications
branch
from
e778bca
to
3d2adc4
Compare
|
@miq-bot add_label bug, gaprindashvili/yes |
lgalis
force-pushed
the
add_option_to_clear_classifications
branch
from
3d2adc4
to
28fdf79
Compare
|
@gtanzillo - please review |
lgalis
changed the title
gtanzillo
reviewed
May 29, 2018
lib/miq_expression.rb
Outdated
| @@ -876,6 +876,9 @@ def self._model_details(relats, opts) | |||
|
|
|||
| def self.tag_details(path, opts) | |||
| result = [] | |||
| if opts[:clear_classifications] | |||
There was a problem hiding this comment.
This looks good. However, maybe there's a better name for this option? Something like-
clear_cache or :no_cache or without_cache
|
Checked commits lgalis/manageiq@6749091~...7c44451 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@gtanzillo - changed the option name to :no_cache |
gtanzillo
approved these changes
May 30, 2018
simaishi
pushed a commit
that referenced
this pull request
Jul 11, 2018
…ions Add option to clear classifications for tag_details (cherry picked from commit e5adfd2) https://bugzilla.redhat.com/show_bug.cgi?id=1591495
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to clear classifications for tag_details
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1579867