Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report chargeback from all regions #17453

Merged
merged 1 commit into from
May 22, 2018

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented May 21, 2018

This change allows to report chargeback from all regions.
It just extends queries with certain region number.

Links

@miq-bot assign @gtanzillo

@lpichler lpichler force-pushed the multi_region_chargeback branch 5 times, most recently from f5a8357 to 05371c7 Compare May 21, 2018 16:45
@jrafanie
Copy link
Member

@lpichler this PR is conflicted

@miq-bot
Copy link
Member

miq-bot commented May 21, 2018

This pull request is not mergeable. Please rebase and repush.

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jrafanie
Copy link
Member

@lpichler looks like the tests are failing.

@miq-bot
Copy link
Member

miq-bot commented May 21, 2018

Checked commit lpichler@b8d84ff with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
7 files checked, 0 offenses detected
Everything looks fine. 👍

@lpichler
Copy link
Contributor Author

@jrafanie @gtanzillo I fixed tests 👍

@gtanzillo gtanzillo added this to the Sprint 86 Ending May 21, 2018 milestone May 22, 2018
@gtanzillo gtanzillo merged commit 656a6c4 into ManageIQ:master May 22, 2018
@lpichler lpichler deleted the multi_region_chargeback branch May 22, 2018 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants