Refactor historical / current log collection

[jrafanie]

This refactoring is required so we can post things other than historical and current logs such as automate dialogs, domains/models, etc.

https://bugzilla.redhat.com/show_bug.cgi?id=1535179

Note, the tests are going to be moved and refactored in a followup PR when I need to add the automate dialogs/domains posting.

[jrafanie]

^ this was the goal. It's hard to see in post_historical_logs but there's some "historical log specific" setup and then the call to post_one_log_pattern.

For an idea of what the automate stuff will look like due to this refactoring:

  def post_automate_models(taskid, log_depot)
    domain_zip = Rails.root.join("log/domain.zip")
    backup_automate_models(domain_zip)

    logfile = LogFile.historical_logfile
    logfile.update(:file_depot => log_depot, :miq_task => MiqTask.find(taskid))
    post_one_log_pattern(domain_zip, logfile, "Models")
  ensure
    FileUtils.rm_rf(domain_zip)
  end

[jrafanie]

This will be cleaned up and put in a nicer place in the automate dialog/models export PR

[miq-bot]

Checked commits jrafanie/manageiq@0881bcf~...76c8e3e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 18 offenses detected

app/models/miq_server/log_management.rb

• ❗ - Line 141, Col 7 - Style/RedundantSelf - Redundant self detected.
• ❗ - Line 148, Col 49 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 148, Col 80 - Style/RedundantSelf - Redundant self detected.
• ❗ - Line 152, Col 1 - Layout/EmptyLinesAroundExceptionHandlingKeywords - Extra empty line detected before the rescue.
• ❗ - Line 167, Col 55 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 167, Col 58 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 37, Col 57 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 37, Col 60 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 44, Col 20 - Style/RedundantSelf - Redundant self detected.

spec/models/miq_server/log_management_spec.rb

• ❗ - Line 155, Col 46 - Rails/FilePath - Please use Rails.root.join('path', 'to') instead.
• ❗ - Line 156, Col 46 - Rails/FilePath - Please use Rails.root.join('path', 'to') instead.
• ❗ - Line 157, Col 88 - Layout/SpaceInsideBlockBraces - Space missing inside }.
• ❗ - Line 158, Col 50 - Rails/TimeZone - Do not use Time.parse without zone. Use one of Time.zone.parse, Time.current, Time.parse.in_time_zone, Time.parse.utc, Time.parse.getlocal, Time.parse.iso8601, Time.parse.jisx0301, Time.parse.rfc3339, Time.parse.to_i, Time.parse.to_f instead.
• ❗ - Line 159, Col 50 - Rails/TimeZone - Do not use Time.parse without zone. Use one of Time.zone.parse, Time.current, Time.parse.in_time_zone, Time.parse.utc, Time.parse.getlocal, Time.parse.iso8601, Time.parse.jisx0301, Time.parse.rfc3339, Time.parse.to_i, Time.parse.to_f instead.
• ❗ - Line 160, Col 115 - Layout/SpaceInsideBlockBraces - Space missing inside }.
• ❗ - Line 168, Col 13 - Style/PercentLiteralDelimiters - %w-literals should be delimited by ( and ).
• ❗ - Line 188, Col 14 - Layout/FirstParameterIndentation - Indent the first parameter one step more than the start of the previous line.
• ❗ - Line 208, Col 14 - Layout/FirstParameterIndentation - Indent the first parameter one step more than the start of the previous line.

[jrafanie]

I'll fix up the cops in a followup PR. Many are from the original code and I'd rather not refactor and appease rubocop here.