Remove :match_via_decendants for ConfiguredSystem::ConfiguredSystem #17430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit tumido@dfa8328 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label gaprindashvili/yes |
|
@lpichler, can you please review this one as well? 🍺 |
|
@miq-bot assign @gtanzillo |
lpichler
approved these changes
May 21, 2018
|
Sorry to bump, can I get this one reviewed/merged, so the bug can be resolved? 😉 @lpichler @gtanzillo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's clean up nonsense Rbac requests for
:match_via_descendantssinceConfiguredSystem::ConfiguredSystemis not a valid relation. This only causesevm.logwarning pollution:For valid relations, please consult Rbac's filterer.rb
Partially fixes: bug 1565266
Related: ManageIQ/manageiq-ui-classic#3952
@miq-bot add_label rbac, bug