Fix current/active server deletability validation #17391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1575077 Note, the UI will need to check server.errors after attempting to destroy the record to see any errors.
jrafanie
force-pushed
the
fix_server_deleteable_validation
branch
from
84ebb58
to
7040201
Compare
|
Checked commit jrafanie@7040201 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
kbrock
approved these changes
May 29, 2018
|
Thanks @kbrock. This is ready to go, once merged, @dclarizio @h-kataria, this PR will allow the UI to check the validations on deletions as described in https://bugzilla.redhat.com/show_bug.cgi?id=1575077#c4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1575077
Note, the UI will need to check server.errors after attempting to
destroy the record to see any errors.