Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infra inventory collections for targeted refresh #17324

Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Apr 20, 2018

The host related inventory collections did not have the
parent_inventory_collections set which was causing targeted refresh to
fail.

The host related inventory collections did not have the
parent_inventory_collections set which was causing targeted refresh to
fail.
@miq-bot
Copy link
Member

miq-bot commented Apr 20, 2018

Checked commit agrare@61bd61d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@agrare
Copy link
Member Author

agrare commented Apr 23, 2018

@bronaghs can you take a look?

@agrare
Copy link
Member Author

agrare commented Apr 23, 2018

@Ladas as a side-note I'd like to understand better why this is needed and if there's a way we could automatically infer this from the models

@chessbyte chessbyte merged commit a68f1f2 into ManageIQ:master Apr 23, 2018
@chessbyte chessbyte added this to the Sprint 84 Ending Apr 23, 2018 milestone Apr 23, 2018
@agrare agrare deleted the fix_host_parent_inventory_collections branch April 23, 2018 14:47
@agrare
Copy link
Member Author

agrare commented Apr 23, 2018

Thanks @chessbyte !

@kbrock
Copy link
Member

kbrock commented Apr 23, 2018

@Ladas could you add some documentation here as to why you want it? thnx

@Ladas
Copy link
Contributor

Ladas commented Apr 24, 2018

@agrare @kbrock here it goes, lets discuss there #17336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants