Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting ManageIQ core to enable PhysicalChassis API endpoint #17320

Merged
merged 2 commits into from
May 14, 2018

Conversation

EsdrasVP
Copy link
Member

This PR is able to:

  • In order to enable PhysicalChassis API endpoint implementation, the chassis class name inflection had to be removed and added to the ExtManagementSystem reference to PhysicalChassis.

@EsdrasVP EsdrasVP changed the title Adjusting ManageIQ core to enable PhysicalChassis API endpoint [WIP] Adjusting ManageIQ core to enable PhysicalChassis API endpoint Apr 21, 2018
@miq-bot miq-bot added the wip label Apr 21, 2018
@EsdrasVP EsdrasVP force-pushed the enable_chassis_api_endpoint branch from 202a76a to 4da3642 Compare April 21, 2018 17:53
@EsdrasVP EsdrasVP changed the title [WIP] Adjusting ManageIQ core to enable PhysicalChassis API endpoint Adjusting ManageIQ core to enable PhysicalChassis API endpoint Apr 21, 2018
@miq-bot miq-bot removed the wip label Apr 21, 2018
@EsdrasVP EsdrasVP force-pushed the enable_chassis_api_endpoint branch from 4da3642 to 41e6996 Compare April 26, 2018 14:05
@EsdrasVP EsdrasVP force-pushed the enable_chassis_api_endpoint branch from 41e6996 to 607d2c2 Compare April 27, 2018 20:19
@miq-bot
Copy link
Member

miq-bot commented May 3, 2018

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented May 10, 2018

Checked commits EsdrasVP/manageiq@607d2c2~...4ca96e3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gtanzillo gtanzillo self-assigned this May 14, 2018
@gtanzillo gtanzillo added this to the Sprint 86 Ending May 21, 2018 milestone May 14, 2018
@gtanzillo gtanzillo merged commit 9780b75 into ManageIQ:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants