Use constant to store ServiceResource status. #17256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzwei
approved these changes
Apr 5, 2018
gmcculloug
reviewed
Apr 5, 2018
app/models/service_resource.rb
Outdated
| STATUS_APPROVED = 'Approved'.freeze | ||
| STATUS_FAILED = 'Failed'.freeze | ||
| STATUS_COMPLETED = 'Completed'.freeze | ||
| STATUS_ACTIVE = 'Active'.freeze |
There was a problem hiding this comment.
Please sort this list alphabetically.
These constants would be accessed from other classes.
lfu
force-pushed
the
contants_for_service_resource_status
branch
from
76cbd18
to
82253ef
Compare
|
Checked commit lfu@82253ef with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
27 tasks
simaishi
pushed a commit
that referenced
this pull request
May 30, 2018
Use constant to store ServiceResource status. (cherry picked from commit 2471626)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These constants would be accessed from other classes.
Required by #17251.
@miq-bot assign @gmcculloug
@miq-bot add_label enhancement, transformation
cc @bzwei