Providers discovery without unspecified discovery types (FIX) #17229
Conversation
| @@ -30,7 +30,7 @@ def self.scan_host(ost) | |||
|
|
|||
| if ping | |||
| # Trigger probes | |||
| ost.discover_types.each do |type| | |||
| ost.discover_types&.each do |type| | |||
There was a problem hiding this comment.
If you don't pass discover_types then this method just pings the target, but doesn't do anything and doesn't raise an Exception, and so looks like it passed. I think maybe we should raise ArgumentError, "must pass discovery_types" or something instead to ensure it's passed. Unless, just pinging is the thing we want it to do? @agrare ?
There was a problem hiding this comment.
Unless, just pinging is the thing we want it to do?
That's not the intention, the UI won't let you submit the form without specifying at least one hypervisor discovery type.
👍 for raising an exception
There was a problem hiding this comment.
ook, replaced by exception
slemrmartin
force-pushed
the
providers-discovery-without-specified-types
branch
2 times, most recently
from
748c037
to
2d72b9b
Compare
| @@ -29,6 +29,7 @@ def self.scan_host(ost) | |||
| end | |||
|
|
|||
| if ping | |||
| raise ArgumentError, "must pass discover_types" if ost.discover_types.nil? | |||
There was a problem hiding this comment.
Probably want to raise on discover_types.empty? instead of just nil.
There was a problem hiding this comment.
ou, right, it doesn't raise Exception if empty, but doesn't improve code as intended.
There was a problem hiding this comment.
I prefer blank?, empty? will fail on nil
Host discovery doesn't raise exception without discovery types options
slemrmartin
force-pushed
the
providers-discovery-without-specified-types
branch
from
2d72b9b
to
d1f8361
Compare
|
Checked commit slemrmartin@d1f8361 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Host discovery raises exception without discovery types options
Cc @agrare
Links
Doesn't block that PR
Steps for Testing/QA [Optional]
In Rails console, put
Host.discoverHost(Marshal.dump({:ipaddr => '10.8.196.29'}))