Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vault credential to factory and provision_job_options. #17207

Merged
merged 2 commits into from
Mar 27, 2018

Conversation

lfu
Copy link
Member

@lfu lfu commented Mar 27, 2018

  • Add ansible_vault_credential into factory.
  • Add vault credential to service's provision_job_options.

Blocks ManageIQ/manageiq-providers-ansible_tower#70.

@miq-bot assign @gmcculloug
@miq-bot add_label enhancement, gaprindashvili/yes, services

Part of https://bugzilla.redhat.com/show_bug.cgi?id=1526048 required to get to Embedded Ansible 3.2.x
Part of https://bugzilla.redhat.com/show_bug.cgi?id=1561116 required to get to Embedded Ansible 3.2.x

@miq-bot
Copy link
Member

miq-bot commented Mar 27, 2018

Checked commits lfu/manageiq@fcbbbb7~...84ee34e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 👍

@gmcculloug gmcculloug merged commit 1d647ba into ManageIQ:master Mar 27, 2018
@gmcculloug gmcculloug added this to the Sprint 83 Ending Apr 9, 2018 milestone Mar 27, 2018
simaishi pushed a commit that referenced this pull request Mar 27, 2018
Add vault credential to factory and provision_job_options.
(cherry picked from commit 1d647ba)

https://bugzilla.redhat.com/show_bug.cgi?id=1561146
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 1d081728431111d2e6d32290a0ffc5ab9f427a3e
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Tue Mar 27 10:22:02 2018 -0400

    Merge pull request #17207 from lfu/ansible_vault_credential_3
    
    Add vault credential to factory and provision_job_options.
    (cherry picked from commit 1d647baa7207499b046aeda30447fab51b78798f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1561146

@lfu lfu deleted the ansible_vault_credential_3 branch September 29, 2018 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants