Refactor ensure_nondefault method for chargeback rate #17188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1552260 Refactor ensure_nondefault method so that a new default? method is created and improved.
|
@miq_bot add_label bug |
|
@miq-bot add_label gaprindashvili/yes |
|
Checked commit hstastna@f2349af with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label bug |
|
@miq-bot assign @gtanzillo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1552260
Needs to merge with the UI PR: ManageIQ/manageiq-ui-classic#3673
Refactor
ensure_nondefaultmethod so that a newdefault?method is created and improved:superis used instead ofdefault?. The method is not private because we need it in chargeback controller, too.