Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report datetime columns(begining and end of resource's existence) in metering report of VMs #17100

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Report datetime columns(begining and end of resource's existence) in metering report of VMs #17100

merged 1 commit into from
Mar 13, 2018

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Mar 7, 2018 •
edited
Loading

New columns are named:

Beginning Of Resource Existence In Report Interval
End Of Resource Existence In Report Interval

Maybe we can find better names. @Loicavenel @gtanzillo

screen shot 2018-03-07 at 14 53 40

Links

@miq-bot assign @gtanzillo
@miq-bot add_label gaprindashvili/yes, enhancement

@lpichler lpichler mentioned this pull request Mar 7, 2018
Merged
1 task
@lpichler lpichler force-pushed the add_beginning_start_of_resource_existence_in_report_interval branch 4 times, most recently from 14aa477 to 3f3d973 Compare March 12, 2018 13:57
@lpichler lpichler force-pushed the add_beginning_start_of_resource_existence_in_report_interval branch from 3f3d973 to 0bfe78e Compare March 12, 2018 14:15
@miq-bot
Copy link
Member

miq-bot commented Mar 12, 2018

Checked commit lpichler@0bfe78e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
9 files checked, 0 offenses detected
Everything looks fine. ⭐

gtanzillo
gtanzillo approved these changes Mar 13, 2018
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@gtanzillo gtanzillo added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 13, 2018
@gtanzillo gtanzillo merged commit 4d5a753 into ManageIQ:master Mar 13, 2018
@lpichler lpichler deleted the add_beginning_start_of_resource_existence_in_report_interval branch March 13, 2018 15:27
simaishi pushed a commit that referenced this pull request Mar 22, 2018
@gtanzillo @simaishi
Merge pull request #17100 from lpichler/add_beginning_start_of_resour…
99b16d7 
…ce_existence_in_report_interval

Report datetime columns(begining and end of resource's existence) in metering report of VMs
(cherry picked from commit 4d5a753)

https://bugzilla.redhat.com/show_bug.cgi?id=1559543
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 99b16d77ed9ee2cfc5bd6993bcba7c5dc385d75c
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Tue Mar 13 10:43:53 2018 -0400

    Merge pull request #17100 from lpichler/add_beginning_start_of_resource_existence_in_report_interval
    
    Report datetime columns(begining and end of resource's existence) in metering report of VMs
    (cherry picked from commit 4d5a75301ccb360748345d1a74bd211e3ce56184)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1559543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
enhancement gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpichler @miq-bot @simaishi @gtanzillo