Consolidate Azure refresh workers #17076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
approved these changes
Mar 1, 2018
|
Checked commit tumido@b5b8aa6 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
tumido
changed the title
tumido
changed the title
|
There's been a little confusion with Azure API timeouts yesterday which resulted in failed refreshes. Today it worked fine so I can confirm the worker picks up correct queues and processes the refresh. Ready to merge. 🚀 |
simaishi
pushed a commit
that referenced
this pull request
Mar 19, 2018
Consolidate Azure refresh workers (cherry picked from commit e6ba045) https://bugzilla.redhat.com/show_bug.cgi?id=1558078
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending PR merges both Azure refresh workers so it can be performed in one worker.
Depends on: ManageIQ/manageiq-providers-azure#216
Related discussion: #16465, ManageIQ/manageiq-providers-openstack#154
One of many requirements for: https://bugzilla.redhat.com/show_bug.cgi?id=1487602
@miq-bot add_label gaprindashvili/yes
cc @Ladas